@Stroudy
Posted
Hey, Great job with this solution you should be proud, A few things I noticed,
- Background and foreground colours do not have a sufficient contrast ratio, Low-contrast text is difficult or impossible for many users to read. Check out this Discover and fix low-contrast text with Chrome DevTools,
- Your heading elements are not in a sequentially-descending order, Should be
<h1>``<h2>``<h3>``<h4>
, You can have multiple<h2>
but they have to be in order, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies. - Missing a
<meta>
description tag for SEO purposes, - It is best practice to have a
<main>
tag inside your body highlighting the main section. - Having better
alt=""
descriptions for accessibility is a must check this out Write helpful Alt Text to describe images, - Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
You have done nothing wrong, Just a small minor improvments for accessibility, You should infact be very proud of this solution! I hope you found some of this information helpful, Happy Coding!💻
Marked as helpful
@anibalcoding
Posted
@Stroudy this is great feedback! Thank you so much! I will implement these solutions. I love the breakdown. Great explanation
@Stroudy
Posted
@anibalcoding, Happy to help, Some really good material to read there to help your site be more responsive and accessible, As long as we are learning we are improving including me, I look forward to seeing some more from you!