Design comparison
SolutionDesign
Solution retrospective
What challenges did you encounter, and how did you overcome them?
I got contrast errors between the background and foreground colors of the links, which were resolved using the Accessibility Insights for Web extension.
What specific areas of your project would you like help with?👍 Any great feedback is appreciated!
Community feedback
- @raulgaliciabPosted 15 days ago
Hi Alberto
Great work and also great additions to the challenge!
Here is the feedback that I see:
- For the CSS variables try to use more descriptive names. This will make the code more maintainable.
- You are using px and rem in different classes for width and height. This might not be very clear for someone else reading the code. Try to use just one for consistency.
Marked as helpful1@alberto-rjPosted 7 days agoHi Raul!
I agree, I really should improve this solution now (note: I was just learning the basics when I implemented it, so I didn't take into account the details you mentioned). But still, thank you very much for your time and your great feedback Raul.
Happy coding :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord