angular scss and typescript , media queries and string interpolation

Community feedback

• 

  Shahjahan Sarfraz•270

  @Jahan-ShahPosted over 1 year ago

  Hi 👋. Well done on completing this challenge. To improve your code I've got some feedback

  But first, Make sure you push code that is not built on GitHub so other people can review your code. As I cannot review your code. I have some suggestions that you can consider.

  • You can include checks for the validity of the Day, Month, and Year.
  • For the day add a check to make sure the user's entered value is not more than the number of days of the respective month. i.e. February cannot have a day more than 28 except for lunar years.
  • For the month add a check to make sure the user's entered value is not more than 12.
  • For the year add a check to make sure the user's entered value is not a future year.
  • Last you can also add form submission on enter.

  I hope you'll find this helpful 😄

  Marked as helpful

  1

  ---

  

  faramarzsakhi•150

  @faramarzsakhiPosted over 1 year ago

  @Jahan-Shah thank you brother great advices and i will make sure to fix all these problems . is it ok to upload angular projects without node-modules cause it has size of 300 mb? and also how could i deploy live site of github pages from a folder that is not root? cause built files are int root/dist/project-name folder

  0

  

  Shahjahan Sarfraz•270

  @Jahan-ShahPosted over 1 year ago

  @faramarzsakhi Hi again,

  1. If you're using angular cli to initialize projects then you don't need to worry about pushing node modules to GitHub. Ps: (node modules are automatically installed when the user run npm install in the project's folder.).

  2. No you can't deploy a site from a folder. To deploy a site to GitHub pages use GitHub actions, GitHub will automatically build the deploy the site. But I would suggest you deploy your site on Netlify or Vercel to avoid any hassle.

  Marked as helpful

  0