Angular Product List with Cart

Community feedback

• 

  Zenos•190

  @ZenosakiPosted 3 months ago

  GOOD JOB ! you finished the challenge i love how u understood the grid functionnality but there are some issues that you need to fix : firs of all you didnt deploy your project in a git hub page so i installed it and open it from the vs code mannually , secondly you didnt make the colors of the add to cart text color , the aspects of the button itself doesnt match the quantity button so when i click on the add to cart it just stretch out , in you page it needs at least one H1 (expl: desserts must be H1), the product cards you made it too much bigger than the original designe and you didnt respect the margin of the main container (that contains the title and the cards) and finally the cart element must be fixed do when i slide down i still see the cart and it's elements but i love how you menaged the functionnality . As a conclusion 10/10 for the functionnality 4.5/10 the front end side , i hope my feedback will help you improve yourself in the future

  1

  ---

  

  Aziz Hmidi•160

  @Paran-oidPosted 3 months ago

  @Zenosaki thank you for your review, however I do not think my work should be rated at 4.5/10, you just can't do the design 100% accurately, for a junior fullstack developer it's not 4.5 that's for sure, yes I missed some details here and there but the app is not that awful on the UI/UX front.

  I deployed the app on Firebase now, took me 3 hours but I am happy I won't face this issue again, for now...

  thank you for your review, I will make sure to not miss create these flaws again on my future projects!

  1