Design comparison
Solution retrospective
This is a good challenge to start with form validation. My JS is not optimised enough. Any suggestions are welcome.
Community feedback
- @wagnnermoraisPosted about 1 year ago
good job, nice animation on inputs fields btw.
i suggest you take a better look in the validation itself, i tried to register the following user and it passed:
first name: w last name: m email: was@123 password: 1
implementing some minimum lengths in each input should work, and about the email input, would be nice to validate with an email regex, theres a lot content in the web about patterns of email validations.
Marked as helpful0@PradneyaSPPosted about 1 year ago@wagnnermorais Thank you very much for the review🙌. It was my first time making a form validation component. I will definitely implement your suggestions.
Edit: I just wanted to say that in India there are people with initials as their first name( Ex: S Somanath ). That is the reason I didn't put any minimum length. I have implemented the code about regex though! Thanks again !!
0@wagnnermoraisPosted about 1 year ago@PradneyaSP i didnt know about that, thanks for sharing this. :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord