Bryan Li• 3,550
@Zy8712
Posted
Hi there! Your site looks great and follows the original design very closely. Nice Work!
Some changes I recommend:
- you should use a
<h1>tag instead of a<h3>tag as headings are meant to be used in order from h1 to h6 without skips. The headings all come with default fontsizes which can be modified usingfont-size(like you already have done) - for improved accessibility you should use a
<main>tag around your page's main content - for your
<body>you should usemin-heightinstead ofheight
Aside from that your scss and html code looks clean and is easy to follow. Great work 👍
Marked as helpful
0
Cynthia• 50
@tina4449
Posted
Thank you so much for commenting. I have fixed my code according to your suggestion and will keep it in mind as I continue. It really helped me a lot.
0
