Easybank landing page | pure HTML SCSS and JS

Community feedback

• 

  Alex Kim•1,325

  @alex-kim-devPosted about 4 years ago

  Hi Connor, I've been inspecting some of your solutions and I think you're doing a great job! I like the visual accuracy and how the code is organized. There's one thing that I spotted - some BEM elements which are nested inside other elements have this type of naming: block__elem1__elem2__elem3. However it's not recommended in the BEM documentation (Guidelines for using elements - nesting). So instead of a markup like this:

  // pug
  nav.desk-nav
    ul.desk-nav__menu
      li.desk-nav__menu__item
        .desk-nav__menu__item__underline
  

  it's recommended to do it this way:

  // pug
  nav.desk-nav
    ul.desk-nav__menu
      li.desk-nav__item
        .desk-nav__underline
  

  Also I've noticed you have a lot of solutions using Svelte, so when I'll be trying it out I'll definitely come back to them and learn. Have a good one!

  2

  ---

  

  Connor Z•5,115

  @zuolizhuPosted about 4 years ago

  Big thanks Alex! @Alex-K1m I was struggled on naming those elements and tried to shorten their names, I will try your strategies on my next project 😎!

  Yeah I'm a big fan of Svelte. For multi pages project, I used Sapper, which is the same thing you learned from Svelte plus its file-based routing system. Highly recommended😆!

  1
• 

  Ovidiu-Antonio•3,125

  @ovidiuantonioPosted over 4 years ago

  Hello,

  Very nice solution! You did a great job! Two thing that I found, and need some improvement, are:

  • add hover state for the article title
  • try to find a better breakpoint for the nav switch. The nav stats getting off the screen. Try to replace 640 with 740 or even 800.

  Happy coding! Keep going!

  1

  ---

  

  Connor Z•5,115

  @zuolizhuPosted over 4 years ago

  @ovidiuantonio Thanks for your feedback! I haven't noticed the state for the articles yet LOL. Thanks for pointing out! I just updated with some box-shadow to the cards as well. 800px is a good break point for the nav bar!

  0
• 

  Magda Kokot•1,425

  @magdakokPosted over 4 years ago

  How cool is that! :D

  1

  ---

  

  Connor Z•5,115

  @zuolizhuPosted over 4 years ago

  @magdakok 😁

  0
• 

  Ramsay Sewell•585

  @ramsaysewellPosted over 4 years ago

  Hey Connor,

  This looks really good! Congratulations on getting it so close to the design, I would say its almost pixel perfect too!

  I like how semantic your code is and the use of BEM is very well respected.

  Great job! Keep it up!

  1

  ---

  

  Connor Z•5,115

  @zuolizhuPosted over 4 years ago

  @ramsaysewell Thanks!

  0