All Done

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Hussain, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all margin from container and wrapper classes because with flex they are superfluous
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  0
• 

  Kawsar Ahmed Fahad•2,660

  @faha1999Posted about 2 years ago

  Hello, Hussain. Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  You might want to use semantic tags like the <main> to wrap your code, instead of divs.

  You could also make use of <section> and/or <article> semantic tags. This would help improve accessibility.

  I hope this helps you. Happy Coding!

  Marked as helpful

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Hussain754, Congratulations on completing this challenge!

  From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.The value you’ve used for the shadow make it too much dark and strong. To improve your box-shadow, you’ve to have in mind two things that make a good shadow, blur and low opacity for smooth shadows. To improve your current shadow, decrease the opacity and increase the blur, try this value instead: box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%); If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/

  2.To improve your component overall responsiveness, something you can do its to create a media query to save space in the pricing section to make each information in a different row. Here’s the code for this media query.

  @media (max-width: 350px) {
  .flex {
      display: flex;
      align-items: center;
      justify-content: space-between;
      padding: 25px 0;
      flex-direction: column;
  }
  }
  

  ✌️ I hope this helps you and happy coding!

  0