@visualdenniss
Posted
Hey there,
your solution looks great overall!
My suggestion would be to use em or rems for font-sizes and other elements (expect for icons, they can be in fixed sizes). Here is a great resource about that https://www.youtube.com/watch?v=dHbYcAncAgQ
Also you seem to be using: display: grid; grid-template-columns: 1fr min-content 1fr; grid-template-rows: 1fr min-content 1fr; height: 100vh;
to center the item. Which seems to be working perfectly. However there is a simpler way of centering as well:
display: grid; place-items: center; will do and save you some lines of code :)
Hope you find this feedback helpful!
Marked as helpful
@madosy
Posted
@visualdenniss honestly, I totally forgot about "place-" property! Thanks for the reminder and the other suggestions.