akarivari-patch-1

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  CSS 🎨:

  • You have used Flexbox correctly, but the only thing missing is setting a height for your 'body' element to vertically center the content. Without a defined height, it doesn't have a reference point for vertical centering.

  • You should avoid using position: absolute on all elements to position them, as position: absolute can make your layout more complex and potentially cause difficulties when positioning elements.

    The possible confusion might have arisen from using display: flex on your <div class="bloco"> and seeing the elements align horizontally. If you want to change the alignment using Flexbox, you can simply use flex-direction to control the direction of the layout.

    The possible values for flex-direction include:

    • row (default): This value arranges the items in a horizontal line, from left to right --- .
    • column: this value arranges the items in a vertical column, from top to bottom |.

  CSS Reset 🔄:

  • You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

    CSS resets that are widely used:

    • Reset CSS
    • "My Custom CSS Reset" by JoshWComeau

  I hope you find it useful! 😄

  Happy coding!

  1
• 

  Wojtek•190

  @Wojtek-APosted about 1 year ago

  Hi, in my opinion you should work a little on the sizes and the font is not the same. Take a look on your "DESIGN COMPARISON".

  0