age-calculator

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  Works great for me!

  I leave you some details:

  • In the body you placed height: calc(100vh - 1px) why -1px? The correct thing for this case would be min-height: 100vh
  • You can do a small reset to remove the margins that come by default in the browsers and use box-sizing: border-box to make it simpler to calculate the paddings and margins:

  * {
      margin: 0;
      box-sizing: border-box;
  }
  

  • You have an error in the console, you can check with the element inspector

  Marked as helpful

  1
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @deepika9107!

  Your solution looks great!

  I have a suggestion for improvement:

  • For semantic reasons, replace your div.container with main.container. This tag change have no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, really good job!

  Marked as helpful

  0