Age Calculator with Vanilla JS

Community feedback

• 

  Arber Lisaj•340

  @arberlisajPosted over 1 year ago

  Hi @danielle I would like to congratulate you on completing the Age Calculator App and I might have a couple quick solutions for your questions

  • Instead of declaring constant variables like this: const dayLabel = day; const monthLabel = month; etc. You want to declare them like this const dayLabel = day , monthLabel = month , yearLabel = year;
  • I see you use function keyword inside methods for an instance forEach(function(monthOfYear) it would've been a lot better if you used arrow like this monthsOfYear.forEach(m=> if(m.month === selectedMonth) // return something)

  All in all good solution and it would be a lot better if you remove the designe directory from you github repo as it is just a liability and it takes space for no good purpose

  Happy Coding :)

  Marked as helpful

  1

  ---

  

  Danielle•160

  @dfeeney96Posted over 1 year ago

  Thank you for your feedback @arberLisaj ! Some great points

  1