Age calculator using vanilla JavaScript, css flex box

Community feedback

• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • For image like .svg are decorative which screen readers will not render it to be important and skip it, so it makes no sense to add alt and leave it blank.

  <img src="./assets/images/icon-arrow.svg" alt="" width= 30px;>

  • Use max-width instead of width to make your card more responsive.

  • Try to add accessibility features like aria, sr-only, title.

  aria : link

  .sr-only:link

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  2

  ---

  

  Kehinde Balogun•315

  @Kehinde13Posted over 1 year ago

  @NehalSahu8055 Thanks for review, it’s really helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  POINTING CURSOR ↗️:

  • Looks like the component's button element has not a pointer, this property plays a major-role in terms of both UI & UX

  ---

  • The cursor: pointer CSS property is important for button-like elements because it changes the cursor from the default arrow to a pointer when hovering over the element. This provides a visual cue to the user that the element is clickable and encourages interaction.

  ---

  • In terms of UI/UX, using cursor: pointer helps to improve the usability of the interface by making it easier for users to identify interactive elements. It also helps to provide feedback to the user by indicating which elements are clickable and which are not.

  ---

  • So we want to add this property to the following button element

  button {
  cursor: pointer;
  }
  

  • Now your component's button has got the pointer & you learned about this property as well

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  2