@oroszlanolo
Posted
Hi, congratulations on completing your challenge!
I have some suggestions for you:
First of all, I recommend structuring your code to different files. Now the index.html
contains everything, but ideally, you would want to have a separate css
and a js
file.
I can see, that the layout could be improved still. I have some suggestions for you:
- Add a max-width to your instead of using different margins at different screen sizes. You could simply set a margin of like 2rem, and add a max-width of like 800px. This is a simple solution, and will work even on some ultrawide monitors.
- I can see, that you are using font-weights, but they seem to differ from the design (your result text is way too thin) I think you should look into that.
- Use bigger btn on big screen sizes. I like how you have set up a grid for the main layout
I hope some of this was helpful. Have a nice day! :)
Marked as helpful
@wicaksana94
Posted
Hello Bálint Balázsi,
Thank you for your feedback. By the way I don't have ultrawide monitors, but your simple solution was helpful I'll update later :)
Have a nice day too :)