Design comparison
SolutionDesign
Solution retrospective
I have created this app with React. It was a nice challenge with its logic and error-handling variety.
Community feedback
- @BlackpachamamePosted 10 months ago
Greetings! you have done a great job š
š Some suggestions
- The
width: 100vw
property is unnecessary, it also generates a horizontal scroll - Do not use
vw
orvh
for thewidth
orheight
of your main. Better userem
,em
orpx
- Use
min-height
andmax-width
, this will help the content stretch or shrink if you need to. Unlikeheight
andwidth
which can cause your content to be cut off on certain screens - You have applied
flex-shrink: 1
in your.App
. Why? does not apply here - The texts above the
input
should actually belabel
. To these you must add thefor
attribute with the same name as theid
of theinput
to which they refer.
Marked as helpful1@GioKhabuPosted 10 months ago@Blackpachamame Many thanks Marcos for such useful hints, I have already made some of the changes.
1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord