Design comparison
Solution retrospective
This is a challenge project from Front End Mentor. I did not strictly follow the design requirements for the project, but nothing critical should be missing. I included some additional accessibility features, such as aria-labels, and I tried to follow most accessibility guidelines. I did not have the time to turn this into a PWA, but I may revisit it in the future and add that support.
This project should work well with Edge, Firefox, and Chrome. I was able to use a trial Browserstack environment, but the time limits meant that I could not do much testing with Safari. If you happen to use Safari and are able to test this, please consider filing a bug report if you encounter any behavior that breaks the project.
I did not write unit tests for this project because it is small. In a production environment, I would have established the list of requirements and then written tests for those requirements. As this is really just a small challenge project, I did not figure it was worth the effort.
The minimum viewport size for this project is around 260px. Anything beyond that and you're pretty much on your own. I figured this would be good enough for most of the available devices out there.
A couple of things I plan on taking care of in the future is a theme for people who prefer higher contrast and also a general cleanup of the redundancy between the theme properties from the light and dark theme respectively. There are also some performance issues that have been highlighted by Lighthouse that I could definitely take care of in the future.
Community feedback
- @dostonnabotovPosted over 1 year ago
Hi, there!
Congrats on completing the challenge.
Everything looks good to me. But, I have one suggestion.
I would appreciate if you could lower the opacity of the border of the
<input>
element or at least change the color to something less bright. It's standing out too much in both the dark and light theme and it would be great if it were less distracting to eyes.As for the viewport, I am not sure it's sure if it's a good practice to care too much for below 300px. 320px is my minimum go-to viewport.
Good luck on your coding journey!
1@av-guyPosted over 1 year ago@dostonnabotov
Thank you for taking the time to provide feedback on my solution.
I modified the original design to include more contrast between the border and the background of the application after evaluating the original design requirements using the CCA tool. The original design did not meet AA requirements for non-text contrast on UI components and graphical elements. I used Google Chrome dev tools vision deficiencies "Reduced contrast" setting and thought that the opacity looked good given an environment where contrast would be an issue. However, I will certainly take into consideration your feedback and see if there is a middle ground that CCA considers satisfactory and also looks good to the eye using deficiency emulation.
Once again, thank you very much for taking the time out of your day to review this. It doesn't go unnoticed and is very appreciated.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord