Design comparison
Community feedback
- @Simplify4Me2Posted about 1 month ago
Hi @1of1baw,
First off, congrats on completing the challenge! ๐ A lot of great things going on here, using clean and well-organized code.
I noticed a tiny typo in your HTML file. On line 8, the
ype
attribute should betype
. That's likely why it's duplicated.Instead of using
input type="text"
, you could switch them totype="number"
. It gives a more intuitive experience for users by showing the numeric keypad on mobile.Good that you're using
new Date(year, month, 0).getDate()
to validate days! But a small remark: you're checking validity of the day even before confirming if the month and year are valid.I hope this wasn't too nittpicky ๐ Happy coding โกโก
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord