Age Calculator done with React

Community feedback

• 

  Better5afe•850

  @better5afePosted about 1 year ago

  Hi Pablo!

  Firstly, congrats on completing this project! I hope you had a lot of fun while making it.

  Please find some minor suggestions from my side below.

  • For better UI, I would advise adding some error text when user is trying to submit empty or incorrect values.
  • I see that you decided to use a max attribute on the year input to block it to the current year, however if you submit a future date still in 2023 (e.g. 10.10.2023), the form is submitted successfully and the result shows up in negative numbers.
  • You can consider removing the up & down arrows from inputs to make them look more neat.
  • Try adding some transition on the hover animations - trust me, it's not much work but the difference is worth it.
  • When it comes to component design, I would create two separate components for the form and the result, just to make the structure more readable.

  Overall, good job and I hope you find this comment helpful.

  Happy Coding! 🎃

  Marked as helpful

  0

  ---

  

  Pablo Hernan Obrach•120

  @pablo-obrachPosted about 1 year ago

  @better5afe

  Thanks for taking the time , im gonna handle errors better next time. Also the two separated components it s a great idea , im new with react (just a month using it) so when it comes to create components i get a lil bit confuse . Anyway thanks for your feedback cheers from argentina

  0