Age Calculator Application (Sass + JavaScript)

Community feedback

• 

  P

  Elyse Kanagaratnam•300

  @elyyysePosted over 1 year ago

  Hey, Malick - I think the error might be caused by a backwards greater than sign on line 48 of your .js file.

  It’s currently written as if (currentDate.getMonth() < birthDate.getMonth()) { ageMonths += 12; }, but I think you’re looking for inputs where the birthday has already occurred this year.

  I hope this helps! I found this challenge difficult and enjoyed reading through your solution.

  0

  ---

  

  P

  Malick Roungou•470

  @mroungouPosted over 1 year ago

  Hi, @elyyyse thank you for your comment. I tried making the change you suggested but unfortunately it didn't seem to fix the bug :(

  0

  

  P

  Elyse Kanagaratnam•300

  @elyyysePosted over 1 year ago

  Hi, @mroungou - thanks for reporting back! Looking back at my note, I'm the one who had the greater/less than sign flipped, not you. So sorry for the unhelpful feedback.

  I took another look at your code and noticed a few things you might find helpful. Obviously any change you make will have downstream effects, but hopefully this will give you a leg up if you decide to do any refactoring.

  • Firstly, JS basically always counts from 0. So in the Date object, 0 = January, 1 = February, and so on. Because of this, when you are calling const birthDate = new Date(year, month, day);, the date you create is one month off.* (credit to this article where I learned that)

  • Perhaps my favorite thing I noticed — by using UTC in let ageYears = ageDate.getUTCFullYear() - 1970;, you actually don't need the later 'if' statement (referenced below) to correct for users who have not yet had a birthday this year. UTC takes care of that for you. It's kind of genius, I wish I had thought of it when building my solution.

  if ((currentDate.getMonth() < birthDate.getMonth()) ||
          (currentDate.getMonth() === birthDate.getMonth() && 
          currentDate.getDate() < birthDate.getDate())) {
              ageYears -- ;
  }
  

  • The same is true for let ageMonths = ageDate.getUTCMonth();. I tested it, and it just works for telling you how many months old your user is — no adjustments necessary. (Though it's probable that in Feb/Mar during a leap year, this might act up a little). Counting days is where things get a bit tricky. I ran out of time on this one, but I can see you've already built-in adjustments to account for these issues.

  * one caveat to my first bullet, if you leave off the date, so Date(year, month, 0), it seems to assume you mean the previous month — so like May 0 = April 30.

  Anyway, that's all from me. I learned a lot about dates and times in JS by reading through your code. Seriously, using UTC like that was so smart. Cheers, Elyse

  0