Design comparison
SolutionDesign
Community feedback
- @0xabdulkhaliqPosted about 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS 📐:
- The
h-screen
utility class is used to defineheight: 100vh
, But we want to usemin-height: 100vh
forsection
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thesection
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then thesection
will start at100vh
, if the content pushes thesection
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
- So we want to use
min-h-screen
utility class to definemin-height: 100vh
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@kietly2kPosted about 1 year ago@0xAbdulKhalid Thank you so much for the advice 🥰. I will keep that in mind when working on future projects and will improve my solution.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord