Age Calculator App - Vanilla JS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these utility classes mt-5, mb-5, after removing you can able to see the changes

  .mb-5 { margin-bottom: 3rem !important; }
  .mt-5 { margin-top: 3rem !important; }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Habiba Mahmoud•50

  @HabibaAbouelyazeedPosted over 1 year ago

  Thanks a lot, exactly what I was looking for.

  0
• 

  Saad Hisham•1,750

  @Saad-HishamPosted over 1 year ago

  you've done an amazing job! I just wanted to share some friendly tips to make your application even better. For better accessibility, it's recommended to wrap the whole application inside the <main> tag instead of using a <div>. I also noticed that you added the font correctly to your application, but it seems like you're not using it. Maybe you have a different preference but just wanted to let you know in case you missed it. Keep up the great work🔥 جميل جداً استمري

  Marked as helpful

  0

  ---

  

  Habiba Mahmoud•50

  @HabibaAbouelyazeedPosted over 1 year ago

  Thanks, Feedback appreciated.

  1