Design comparison
Solution retrospective
Things I found difficult in this challenge
JS
- Date validity (e.g. There are only 28/29 days in February)
- Statements for Loop Year
I got an error with using dayjs() so I was not able to use the isLeapYear() plug-in. I also struggled with creating statements for the date validity, and for this I need some suggestions and feedback in order to further improve my code as well as my skills in logic and programming.
I am new to JS and I thought that doing some projects could somehow help me familiarize with some concepts in JS, even the complex ones.
UPDATE: For some reason, the website's functionality does not work despite its several commits (It works on localhost just fine, though)
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder π.
Congratulations on successfully completing the challenge! π
- Add
min-height:100vh
to youmain
to properly center the card. - Don't use multiple <form>, use only one form with input inside it with proper submitting for javascript handling.
I hope you find this helpful.
Happy codingπ
Marked as helpful1@cheribellaPosted over 1 year ago@NehalSahu8055 Thank you for your feedback, I learned something new today, thanks to you. π€
0 - Add
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS π¨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- You already using
Grid
layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
main { min-height: 100vh; }
- Now remove these styles, after removing you can able to see the changes
.container { margin: 4rem 0; }
- Now your component has been properly centered
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
1@cheribellaPosted over 1 year ago@0xAbdulKhalid Thank you so much for the heads up! π€ It was my bad for not noticing these subtle parts. I have huge admiration and respect for the likes of you.
0@0xabdulkhaliqPosted over 1 year ago@oyasumibella Glad you found it helpful ! π€
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord