Design comparison
Community feedback
- @KrishnaVishwakarma1595Posted about 1 year ago
Hi, @defydef
Nice solution. Good job. Although, I've some recommendations that can improve your solutions more -
-
The user can fill the negative values to the inputs using keyboard arrow down/up keys. To prevent this you can provide
min="1"
attribute to inputs so user can enter negative values. -
We can't able to focus on the input by clicking on the label. However, labels have
for=""
attribute with the values of the input's name attribute value. Instead, you should giveid="day"
also to make this possible. -
After the submission, you can reset the input fields so that user don't need to clear them manually again.
Hope these points will help you. The solution looks really good.
Happy Coding
0@defydefPosted about 1 year agoHi @KrishnaVishwakarma1595
Thank you so much for your recommendations 😃 I'll modify my solution and incorporate these suggestions.
Happy coding 🎉
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord