Design comparison
Solution retrospective
I need some help, for some reason the years and days result is inverted and i can't figure out why. Any help is much appreciated.
Community feedback
- Account deleted
Very nice work ✨, Congratulations
it seems like you inverted the
id
in theHTML
code, you just have to invert theid
in the line 37 and theid
in the line 39, then everything must work perfectlyGood luck in the next 🔥, keep going on
Marked as helpful1@ClaudiuSonicaPosted over 1 year ago@MasterMousa Thanks you for pointing that out, i finished the project last night and i stayed like 2 hours trying to figure out the problem, i just couldn't see the ids :))))
1Account deletedyou're welcome @ClaudiuSonica
happy coding ;) and good luck
1 - @alex931dPosted over 1 year ago
hello great solution and very nice javascript code. regarding your question: i notice in your html that you have the days id in the year container and so on to fix this simpliy change the order of the id's
also i have some improvements you could do
- don't use id's or classes to select elements use data attributes instead
- don't use getelementbyid since its outdated use document.queryselector instead
- splice your javascript document to smaller files you can simpliy do that by make a new file and link the file in you'r markup
Marked as helpful1@ClaudiuSonicaPosted over 1 year ago@alex931d Thanks for the info and much more for the tips, i'll try and implement what you've told me
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord