Design comparison
Solution retrospective
Please guys take a look at my codes, the css and js, i just followed my heart when building them without so much help from the internet, it works though, but i feel there could have been a better way in writing the codes, thank you.
Community feedback
- @EngProvidencePosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
I have some little observations which I know you might haver forgotten the hover effect on the arrow is not functioning check it out.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding from emperor pro!
Marked as helpful1 - @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- The
overflow: hidden
property forbody
is not necessary. because the flow of child element (component) needs to be visible for mobile devices which may result in the component being cut off on smaller screens.
- So feel free to remove
overflow: hidden
style rule frombody
this will help you to write efficient code and makes your code more reusable.
- But after removing that you want to add
margin: 0
to unset default margin applied tobody
by browser
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@ify47Posted over 1 year ago@0xAbdulKhalid i will do just that, but what do you think about the entire css
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord