@Dudeldups
Posted
Hello!
Very nice result including the JS logic to count the date. I just see one thing to improve:
You're setting the color
in the style attribute with JS. It'd be better to just add another class to the className, because inline-styles are harder to maintain especially in a bigger project. This way, you'd also have all your CSS in one place and don't have to search 'Why is my text red?' ( -> Always think about your future self... and other developers looking through your code) 😄
Oh and you forgot to connect the labels to the inputs (also input tags are self-closing, no need to add a closing tag)
Overall, very well done! 👏
Marked as helpful
@AlyferJT
Posted
@Dudeldups Hi Arne! Thanks for the feedback... Yep, with that in mind. I have set all static styles on App.css file, and the dynamic style with JS, just to train my knowledge on React!