Design comparison
Solution retrospective
Hi there, this one i struggled XD... I made this with what i learned this last week, so i wanted to challenge myself with some more difficulty. I really liked the result, besides there is things that i could do better, and would really aprecciate every feedback. Thanks.
Community feedback
- @DudeldupsPosted 9 months ago
Hello!
Very nice result including the JS logic to count the date. I just see one thing to improve:
You're setting the
color
in the style attribute with JS. It'd be better to just add another class to the className, because inline-styles are harder to maintain especially in a bigger project. This way, you'd also have all your CSS in one place and don't have to search 'Why is my text red?' ( -> Always think about your future self... and other developers looking through your code) 😄Oh and you forgot to connect the labels to the inputs (also input tags are self-closing, no need to add a closing tag)
Overall, very well done! 👏
Marked as helpful1@AlyferJTPosted 9 months ago@Dudeldups Hi Arne! Thanks for the feedback... Yep, with that in mind. I have set all static styles on App.css file, and the dynamic style with JS, just to train my knowledge on React!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord