@principlebrothers
Posted
Hello Affan Shaikh 👋🏽,
You have a good job completing this project, congratulations! 🎊
I hope this feedback helps
HTML SEMANTIC
It will be more appropriate to use semantic elements in your code as it will help with Search Engine Optimization (SEO) and accessibility. Example instead of using a lot of <div>
you could use <section>
tags, also fore accessibility, if you use <div>
tags, you could make it accessible and meaningful to screen readers by using accessible elements such as aria-label
, role
, aria-labelledby
etc. You can learn more from W3
README
It's important to update your README.md
since that gives first hand information about your project. Hiring manger will get to see how well you document you project from your README.md
file. Kindly update the template given by Frontend Mentor to make your project more professional.
FINALLY
There were errors when I input leap year date and the other attach dates29 - 02 - 2016
,28 - 2 - 2020
, 1 - 2 - 2020
. Kindly check it out. I think it is the whole of Feb dates.
I hope this helps . In all your I like your code organization 🌟
Happy coding 🫶
Marked as helpful
@Terminal239
Posted
@principlebrothers Thanks for the advice, have implemented the necessary changes.
@principlebrothers
Posted
Hi Affan Shaikh,
I am glad the suggestion helped.
I checked it out and it is working perfectly.
You rock