Skip to content
Submitted over 1 year ago

Age calculator app

Affan Shaikh•440
@Terminal239
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Age calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Please share feedback on the code structure and design layout and how I could improve things.

Also, am using the rem units for the padding and margin because it helps things on the response side and keeps things clean. This is a controversial choice and after much research on px vs rem, I settled on rem when I found that Kevin Powell, one of the leading CSS professionals, goes for rem as well.

Community feedback

  • Ernest Anyewe Adonu•110
    @principlebrothersPosted over 1 year ago

    Hello Affan Shaikh 👋🏽,

    You have a good job completing this project, congratulations! 🎊

    I hope this feedback helps

    HTML SEMANTIC

    It will be more appropriate to use semantic elements in your code as it will help with Search Engine Optimization (SEO) and accessibility. Example instead of using a lot of <div> you could use <section> tags, also fore accessibility, if you use <div> tags, you could make it accessible and meaningful to screen readers by using accessible elements such as aria-label, role, aria-labelledby etc. You can learn more from W3

    README

    It's important to update your README.md since that gives first hand information about your project. Hiring manger will get to see how well you document you project from your README.md file. Kindly update the template given by Frontend Mentor to make your project more professional.

    FINALLY

    There were errors when I input leap year date and the other attach dates29 - 02 - 2016 ,28 - 2 - 2020, 1 - 2 - 2020. Kindly check it out. I think it is the whole of Feb dates.

    I hope this helps . In all your I like your code organization 🌟

    Happy coding 🫶

    Marked as helpful
    0
    Affan Shaikh•440
    @Terminal239Posted over 1 year ago

    @principlebrothers Thanks for the advice, have implemented the necessary changes.

    0
    Ernest Anyewe Adonu•110
    @principlebrothersPosted over 1 year ago

    Hi Affan Shaikh,

    I am glad the suggestion helped.

    I checked it out and it is working perfectly.

    You rock

    0
  • Danish Mushtaq•310
    @Danish49Posted over 1 year ago

    This is perfect set the height of the body ko 720px because this is the viewport height of various laptops it will make the design more accurate. Code is also properly structured well done 👍🏻. Keep it up smart coder.

    Marked as helpful
    0
    Affan Shaikh•440
    @Terminal239Posted over 1 year ago

    @Danish49 Thanks for the feedback!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord