Age Calculator App / CSS and Vanilla JavaScript

Community feedback

• 

  P

  Krishna Vishwakarma•1,390

  @KrishnaVishwakarma1595Posted about 1 year ago

  Hello, @Zdravko93

  I've some points for you to improve the solution -

  • Your body has overflow: hidden and because of that I'm not able to scroll because some of the part of the container is hidden. Instead, provide overflow-y: auto to the body.

  • That's nice that you provided the modal for the error message. But, If we try to submit an empty form it shows the modal, as well as the error message for the day field. I think if you want to show the error message too, then show it for all fields otherwise don't show them just mark the field border red.

  • If I fill the day field with a valid value for example: 15 and hit submit button. It shows the error modal and the error message as well for the day field like "Must be a valid date", instead it should show the message for other fields, cause the day field has the valid value. I think you must check the error handling once.

  • You can provide a min="1" attribute to the input fields so the user won't be able to decrease the values to negative values using the keyboard arrow down/up keys.

  I hope these points will help you to make your solution better. Keep mentoring!

  Happy Coding

  Marked as helpful

  0