Age calculator app built with html, css and javascript
Design comparison
Solution retrospective
It took me a few days to complete the challenge and I feel like I could've made it better
Are the HTML structure semantic? if not, what could I change? Is there any way I could refactor the JavaScript code to make it look more clean and legible?
Any feedbacks would be appreciated, thanks!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS π:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
2 - @Map4chePosted over 1 year ago
I checked your code and you have a clean code, but may you could try to guest or imagine always, that the user is going to put everything wrong, try to think waht could put the user in all fields, and find the answer or the message that should appears in all the scenarios, after you create the base code, with the logic and everything working, try to find all the paths that the user could takes, to show them an error or an answer
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord