Design comparison
Solution retrospective
Hello Dear Community
I would hesitate to do this challenge because of its functionality but I did it and it was enjoyable, I thought It was going to be harder than that but I was wrong
In this solution I used framer-motion for animation and TailwindCss for styling
Thanks for viewing, any recommendation is appreciated
Community feedback
- @Ailin-GlezPosted over 1 year ago
Hello, Mehdi. Very nice challenge! Just commenting on some details I saw, which could improve your application:
- if you change the year, it recalculates automatically without pressing the button (I like it better like this, but for the month and day it doesn't update automatically and it would be nice to unify the behavior).
- the validation of the year in the future only appears if the day and month are valid.
On the other hand, it looks great and very close to the original design! Congratulations!
Marked as helpful1@siavhnzPosted over 1 year ago@Ailin-Glez
Hello Ailin
-
Your right I handled automatic calculation only on last field its better to do it for all field
-
validation take apart in sequence. if you pass tomorrow (07/06/2023) for instance to the fields it throws an error, in other hand if you pass only year (2024) and leave other field blank you got an error too
Your comment made me happy :) Thanks a lot
HappinessEmoji :D
0 - @grace-snowPosted over 1 year ago
This allows invalid dates to be submitted like 29th dev on non leap years. I think you should be using a date library in this
You’re also missing essential foundational form html like the form itself, associating labels and inputs, associating errors and inputs, announcing errors to screenreaders...
All of this is so much more important than setting speed goals
Marked as helpful1@siavhnzPosted over 1 year ago@grace-snow
Hello Grace, I got happy for your suggestions
-
Your right I even didn't think about a date library, I had to do it
-
what a forgetfulness.(form, ...) 😬 😥
-
I don't set speed goals, I just track my estimated work time because:
-
It forces me to focus
-
It shows me how much time for each part of solution I spend
-
It encourages me to work more
-
It encourages me to have specific time for work (8 am to 5 pm for instance) and It tells me If I don't do my solutions I miss my work time.
-
It warns me If I rush to code without thinking about a solution I fell into a vicious circle where I try to solve my problem more far away from a solution. in fact I did it last night where I tried to create a box with rounded corner where only rounded corner has color and I tried to do that with gradient and took me 4 hours and nothing. this challenge
I gained a lot from your comment
HappinessEmoji :D
Thanks
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord