Age calculator

Community feedback

• 

  ezecoder•870

  @3eze3Posted about 1 year ago

  Hi Elisabeth Erkekoglou good job with your code I have some recommendations regarding the logic:

  JavaScript:

  • Answering your question that you only run your program once, you don't need any other function , you just have a bug in how you handle events and how you get the inputs when clicking.

  Let's see your code:

  /*inputs values*/
  
  let day = inputDay.value;
  let month = inputMonth.value;
  let year = inputYear.value;
  
  /*Current Date*/
  let currentDate = new Date();
  let currentYear = currentDate.getFullYear();
  let currentMonth = currentDate.getMonth() + 1;
  let currentDay = currentDate.getDate();
  
  /*Results*/
  let years = currentYear - year;
  let months = currentMonth - month;
  let days = currentDay - day;
  

  The first thing is that you are taking the value of the inputs when there is no value, for that reason that you get the current date always and does not change even if we enter values.

  To obtain the values of the inputs we do it at the moment of giving click and not before since they do not have value, this way we can work with these and to make the respective calculations.

  And also I see a lot of duplication in your code, you could simplify with functions that only handle single responsibilities or modularize by classes, to have less problems in the future.

  I can't see in depth your code, but I hope this is useful for you. And if you don't understand something feel free to write me. Happy coding.🍟

  1