Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advisor Generator App with React and Vite

Miguel Angelβ€’ 80

@IscMiguelAngel

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my third challenge, and I decided to do it again with react to practice. This time I discovered the use of the "useEffect" Hook.

Any comment is welcome, greetings.

Community feedback

Adrianoβ€’ 34,090

@AdrianoEscarabote

Posted

Hi Miguel Angel, how are you?

I really liked the result of your project, but I have some tips that I think you will enjoy:

  • To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is.
  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag.
  • images must have alt text unless it is a decorative image, for any decorative image each img tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as a screen reader.

The rest is great!

I hope it helps... πŸ‘

Marked as helpful

0

Miguel Angelβ€’ 80

@IscMiguelAngel

Posted

@AdrianoEscarabote Hi!

Thank you very much for your comments. I have fixed the accessibility bugs, however, I would like you to give me an opinion more than just accessibility, I would like you to give me an opinion about the technology that I am using, in this case REACT JS. I invite you to review the code on GITHUB and tell me what you think.

0
Adrianoβ€’ 34,090

@AdrianoEscarabote

Posted

@IscMiguelAngel it would be a pleasure to do that, unfortunately, I haven't studied this technology yet, but it is on my study list!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord