advise-generator-app

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello M A, You have done a good work! 😁

  Some little tips to improve your code:

  • add margin: 0 to the body to remove the scrollbar of browser
  • add main tag and wrap the card for improve the Accessibility
  • also you can use article or blockquote tag instead of a simple div to the container card for improve the Accessibility
  • you can use picture tag to change image by resolution istead of deco class -> read here
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  M A•170

  @MikkobellyPosted almost 2 years ago

  @denielden Thank you so much for your advice! I'll keep working on it!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @Mikkobelly You are welcome and keep it up :)

  0