Advise Generator with Vanilla JS

Community feedback

• 

  invictus•120

  @invictus1032Posted about 2 years ago

  You should add {cache: "no-store"} param to your fetch call to prevent your request from getting cached. That way, you wouldn't receive the same advice when you roll the dice. Other than that, it's excellent!

  Marked as helpful

  1

  ---

  

  Santiago Betancur•20

  @sbetavPosted about 2 years ago

  @invictus1032 Updated! Thanks for your feedback.

  0
• 

  Mohamed Abdul Rahman•240

  @mdabdulrahmanPosted about 2 years ago

  Hi @sbetav,

  Your Solution is really good!

  Tips :

  1.Wrap all the content in the <main> tag so you couldn't get an landmark error

  2.Use atleast one <h1> tag

  Thanks!

  Marked as helpful

  1

  ---

  

  Santiago Betancur•20

  @sbetavPosted about 2 years ago

  @mdabdulrahman Updated! Thanks for your feedback.

  1
• 

  invictus•120

  @invictus1032Posted about 2 years ago

  How did you freeze the container's width? Mine is adapting to the advice's length.

  0

  ---

  

  Santiago Betancur•20

  @sbetavPosted about 2 years ago

  @invictus1032 You can add max-width on css properties

  1