Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

advice-generator-app-main

@abdelrhmanKh

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hope To Give Me any Suggestions to Improve myself

Community feedback

cacosted 570

@cacosted

Posted

Hello @abdelrhmanKh congrats your solutions looks great.

I have some suggestions, first I noticed a rare jump between the content and when the fetch loads the real content, maybe you could do skeleton loader to avoid this.

Also, I checkout the main.js and you can change all the let for const because you are not reassigning those variables.

//Current
let advice = document.querySelector(".advice");
let adviceId = document.querySelector(".advice-Id");
let btn = document.querySelector(".get-advice");

//New
const advice = document.querySelector(".advice");
const adviceId = document.querySelector(".advice-Id");
const btn = document.querySelector(".get-advice");

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord