advice-generator-app-main

Community feedback

• 

  cacosted•570

  @cacostedPosted about 2 years ago

  Hello @abdelrhmanKh congrats your solutions looks great.

  I have some suggestions, first I noticed a rare jump between the content and when the fetch loads the real content, maybe you could do skeleton loader to avoid this.

  Also, I checkout the main.js and you can change all the let for const because you are not reassigning those variables.

  //Current
  let advice = document.querySelector(".advice");
  let adviceId = document.querySelector(".advice-Id");
  let btn = document.querySelector(".get-advice");
  
  //New
  const advice = document.querySelector(".advice");
  const adviceId = document.querySelector(".advice-Id");
  const btn = document.querySelector(".get-advice");
  

  Marked as helpful

  0