Advice-generator-app using Fetch API in JS

Community feedback

• 

  P

  Jaylou Rasonabe•650

  @JlordS32Posted about 1 year ago

  Congrats on completing this challenge Hibi4. A couple of suggestions that I can maybe add to your solution:

  You can try adding padding: 0 30px for your div_advice just so it looks a little nicer and also add 'box-shadow: 0px 0px 30px -3px #52FFA8;' for the class .dice_icon_logo to give that green shadow effect as the design suggested and make sure that it only happens on hover.

  I have also noticed that the quote never loads on page reload, you can maybe try invoking the function you've created generateAdvice() at the bottom of your main.js, make sure to wrap it in DOMContentLoaded listener so it only calls the function on page reload. It should look something like this:

  document.addEventListener('DOMContentLoaded', () => {
     generateAdvice()
  })
  

  Overall, you're doing pretty great! You're off in a good start my friend. Happy coding!

  Marked as helpful

  0

  ---

  

  Hibi4•210

  @Hibi4Posted about 1 year ago

  Hi Jaylou

  Thank you for your help.

  You not only answered my question, but you also allowed me to improve my code by offering me new suggestions.

  0
• Account deleted

  try this for button ->

  .main {
     add position: relative;
  }
  
  .btn {
     position: absolute;
     bottom: 0;
     left: 50%;
     transform: translate(-50%,50%);
  }
  

  0

  ---

  

  Hibi4•210

  @Hibi4Posted about 1 year ago

  Hi Abdullah

  Thank you for your comment. Your solution helps me to resolve my problem.

  2