advice-generator-app

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="advice-container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  itsKrish01•420

  @Itskrish01Posted over 1 year ago

  Hello there,

  Great work with using Vanilla JS building this project, While reviewing your work, I noticed a few areas that could benefit from improvement in the CSS section. In particular, the way you centered the container could be optimized by using flexbox instead of absolute positioning, which can lead to issues with the mobile view.

  Absolute positioning can cause problems on mobile devices as the elements can become too small to read or interact with. Additionally, it can be challenging to position elements accurately when the screen size changes.

  Therefore, I suggest using flexbox to center your container, which will ensure your design is responsive and adapts to different screen sizes. Flexbox is a powerful tool for controlling the layout of elements and is particularly useful for creating responsive designs.

  Thanks

  Marked as helpful

  0