Advice-generator-app

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge!🎉. That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. I noticed that your app can take some time to load, and it might be a good idea to add a loader to improve the user experience. You can add a loader while fetching data from an API, you can follow these steps: add this code in ur javascript with css of loader in ur stylesheet

  const loader = document.getElementById('loader');
  
  function showLoader() {
  loader.style.display = 'block';
  }
  
  function hideLoader() {
  loader.style.display = 'none';
  }
  
  // Example of fetching data from an API
  btn.addEventListener("click" , ()=>{
  showLoader();
  fetch("https://api.adviceslip.com/advice").then(response =>{
  return  response.json()
  }).then(data =>{
  hideLoader();
  const advicedata = data.slip;
  display.innerHTML=advicedata.advice
  id.innerHTML=advicedata.id
  }).catch(error =>{
  console.log(error)
  })
  

  Marked as helpful

  0