advice-generator-app

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 1 year ago

  Hi

  There are some foundational issues in your CSS that I wouldn't expect to see in a challenge of this level. It implies to me you need to work more on simple UI challenges to solidify essentials

  For example

  • height 100vh instead of min-height
  • explicit widths on the component instead of max-width (and should not be in px)
  • font size in px (critical accessibility failure! See this post)
  • desktop first instead of mobile first styles (I would recommend using the picture element for the divider btw - better for performance than loading two background images)
  • misused headings. The advice number is the heading for this content. The quotes should be in paragraphs
  • you have an on click on a non-interactive element, meaning this is totally unusable for LOADS of people! That is a major problem. This needs to be an accessibly named button. HTML element choice is extremely important and I've written a post about this as well. I have a feeling I've raised similar issues on your solutions before (but could be wrong). Do not do any more js projects until you focus in on getting HTML and CSS foundations right.

  0