advice-generator-app

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these recommendation:

  				**HTML**
  

  ✅ Use HTML5 semantic elements. Make sure correct use of the HTML5 semantic elements like: header, footer, main, nav, article, section. It’s will help you to write more structured piece of code. And please, don't use identifiers.

  <section class="container">
        <h1>ADVICE #<span id="adviceId">117</span></h1>
        <p>“<span id="adviceQuote">It is easy to sit up and take notice, what's diificult is getting up and taking action.</span>”</p>
        <img src="/images/pattern-divider-mobile.svg" alt="" >
        <div class="dice" id="adviceBtn">
          <img src="/images/icon-dice.svg" alt="">
        </div>
      </section>
  

  ✅ Set a meaningful img alt attribute. It’s best practice for SEO purpose.

  <img src="/images/pattern-divider-mobile.svg" alt="" srcset="">
  <img src="/images/icon-dice.svg" alt="">
  

  ✅ Avoid complex wrapping. For better performance please tried to avoid unnecessary wrapping. It will create unnecessary node in your HTML tree and reduce performance too.

   <div class="dice" id="adviceBtn">
          <img src="/images/icon-dice.svg" alt="">
        </div>
  

  ✅ Write Code Comments. It’s best practice to write human-readable code. Tried to comment your block of code. It will help you or any other developer to refactor the piece of code blocks.

  				**CSS**
  

  ✅ Use a CSS reset . By default, browsers don’t apply the same default styling to HTML elements, a CSS reset will ensure that all element have no particular style. For example: css-reset

  ✅ Write consistent CSS. At the beginning part of the project you can set some rules for maintain throughout to your entire stylesheet. If you follow the convention or BEM, you’ll be able to write CSS without being afraid of side effects.

  ✅ Use rem’s or em’s. Using rem’s or em’s is more dynamic way instead of using pixels. Try to use rem’s or em’s rather than pixels.

  ✅ Avoid !important. For avoid code collusion and if you don’t want to break normal flow of browser behavior with your CSS don’t ever use !important.

  I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  0