Skip to content
Submitted over 2 years ago

Advice_Generator_App

JB•80
@JB-Doffemont
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

Hello guys !

This is my second challenge in front-end mentor. I used SCSS for the second time and use Javascript to interact with the API with fetch.

If anyone wants to give me a feedback on my code, feel free to do it !

Thanks a lot :)

Community feedback

  • Steve Xero•210
    @stevexeroPosted over 2 years ago

    Looks great! The margin between the card's header ('advice #') and the quoted text is perfect! I'd make the same margin between the bottom rule and the quoted text as well.

    I would put the JavaScript file(s) in the root of the project or in a 'scripts' folder (also in the root), and not in the assets folder. Save those for media.

    Great work!!

    1
    JB•80
    @JB-DoffemontPosted over 2 years ago

    @steveanthony999 Hey Steve !

    Thanks for your feedback, appreciate it ! :)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord