Skip to content
Submitted about 2 years ago

Advice-Generator

Shaughn Roque•150
@shaughnroque
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

Finished this a while back and forgot to post the solution. Had some trouble at first to get the api to work with github pages but found a solution to that. Any feedback is welcome! Thank You!

Community feedback

  • Efosa Collins EVBOWE•365
    @efecollinsPosted about 2 years ago

    Hello @shaughnroque, congrats. You made a beautiful project. I have some suggestions for improvements which you can add upon your consideration.

    • It's good practice to have your h1 before any other headings. You can change this <h2 class="id">ADVICE #</h2> to <h1 class="id">ADVICE #</h1>.

    Also, change <h1 class="quote">""</h1> to a paragraph element or blockquote.

    • I haven't been able to find a solution to this but you can. For the responsiveness, from 701px - 1088px, your advice-app becomes distorted.

    I know you can solve this. Cheers!

    Marked as helpful
    0
    Shaughn Roque•150
    @shaughnroquePosted about 2 years ago

    @efecollins Thank you for the feedback! I will look into the responsiveness from 701px - 1088px.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord