Submitted over 2 years ago

Advice-Generator

Shonuff•280

@TheShonuff

Preview site View code

This is a solution for...Advice generator app

HTML
CSS
JS
API

2junior

Design comparison

SolutionDesign

Solution retrospective

After being away for a few years, this is my first challenge project. I'm happy that it's functioning as intended but I've seen my CSS break in a few cases. I don't think I setup my flex model correctly to account for the longer quotes. If you have the time to supply any type of feedback it would be greatly appreciated. Thank you.

Community feedback

Account deleted
Hello there! 👋

Congratulations on finishing your challenge! 🎉

I have some feedback on this solution:

put the quote inside a <blockquote> tag instead of p to be more semantic

check the HTML report to fix accessiblity issues

add cursor pointer to button container so that the user knows its clickable

i hope this is helpful and goodluck!
Marked as helpful
1
Shonuff•280
@TheShonuffPosted over 2 years ago
@Old1337 Thank you for the feedback. I've pushed some of the changes you've recommended. Do you have any recommendations for generating HTML reports to fix accessibility issues. This is something I did not consider to be honest. I found a vscode plugin. I did use a website to do a scan and found some issues.

ETA: just noticed the accessibility report generated in this page...
0
Евгений•50
@rahunakPosted over 2 years ago
thanks for this code : {cache: 'no-store'} it decided my problem
0
Shonuff•280
@TheShonuffPosted over 2 years ago
@rahunak took me a while to figure this one out too. I missed it several times in the mdn response documents.
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord