advice-generator-app

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Bruno,

  Congratulations 🎉 for completing this challenge, your API component looks great, and it is great that you used flex to center the card. I have some suggestions I want to address:

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. Since you have a max-width on your card, there is no need to use a media query.
  3. Even though your API is functional on normal browsers, it won't work on Firefox without the clear cache e.g. fetch(URL, {cache: 'no-cache'})

  Overall, great work and wish you the best for your future projects 👍.

  0