Advice Gernerator

Community feedback

• 

  Alex•3,130

  @Alex-Archer-IPosted 4 months ago

  Hey!

  Neat work =)

  To make some load effect you can add any element on the place of advice text. Animate it with CSS or JS, and than after fetching, remove this element, for example, with display: block. You can look at my work - I placed the loading message, but, as I said it could be any element with animation or without.

  By the way, why did you use element.onclick instead addEventListener? i tried to find the pros of them but didn't find anything particular important.

  Marked as helpful

  1

  ---

  

  Artur Neri•230

  @Artur-NeriPosted 4 months ago

  What's up, @Alex-Archer-I? Thanks for the animation tip. Will remember that on my next challenge!

  Me using element.onclick is no preference of mine, I just used becaus it was the first thing that came to mind. I have no idea if one is better than the other, but your question made me think that it is better if I think about the aproaches I am taking and consider the pros and cons, so thank you for that.

  1

  

  Alex•3,130

  @Alex-Archer-IPosted 4 months ago

  @Artur-Neri

  As far as I find the main difference of them is that with element.onClick you can add only one function and with addEventListener - many. So that really could be a thing in the big projects.

  And, hey, glad that I could help. Hope to see cool animation thing you'll make =)

  1
• 

  Lance•1,580

  @IzykGitPosted 4 months ago

  Good job! If I was to go about making a loading animation I would have two different classes for the icon.

  One that is a static class and another class that contains a looping animation. When the user clicks and makes a fetch requests this you could have the element's static class switch to that animation class. Then once the fetch request is complete, have the class be switched back to the static class.

  This shouldn't required too much CSS or Javascript to do. Or if you were to do this project in a framework there are lots of libraries that could handle this as well!

  Keep up the good work

  Marked as helpful

  0

  ---

  

  Artur Neri•230

  @Artur-NeriPosted 4 months ago

  Hey, @IzykGit. Thanks, man! I could definitely use .finally() to change the animated class to the static one, right? Thank you once again.

  0