Advice Generator with html , css , javascript and api

Community feedback

• 

  dgjenni2•320

  @dgjenni2Posted about 2 years ago

  The sizing around the transition of the medium query appears broken. Right when it transitions from mobile to desktop, the container gets shrunken down to a skinny column of text. If you avoid setting the max-width to 30% and just use a fixed max-width and margin: 0 auto, then the container should continuously grow as a percentage of the screen until that fixed, maximum size (say 780px) you would want it on the desktop view, and the margin css should keep it centered.

  I would also recommend min-width rather than max-width for the media query to make the css developed in a mobile first patten, which should allow you to minimize the amount of css overall.

  Marked as helpful

  1

  ---

  

  yuvraj•90

  @yuvraj0003Posted about 2 years ago

  @dgjenni2 thanks for your suggestion brother . It is very helpful

  1