Advice Generator with API

Community feedback

• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • put the quote inside a <blockquote> tag instead of h2 to be more semantic

  i hope this is helpful and goodluck!

  Marked as helpful

  1

  ---

  

  HualDev•850

  @HualDevPosted over 2 years ago

  @Old1337 thanks a lot

  1
• 

  Lorenzo Franco•480

  @LfrancosPosted over 2 years ago

  HualDev this is looking really good!

  There are a couple of things that I think you can work on to improve what you have.

  • Right now you are not using the fonts that you are adding in your html. I would add to the body "font-family: 'Manrope', sans-serif; "

  • Also I feel the container is stretching a little more than the design shows, not that yours looks bad, but if you want to make it look a little more like the design you can add a "max-width: 540px" this will help to make sure the container will not be bigger than that.

  • I would make sure the width and the height of the Circle is the same. That way you will know that it is a perfect circle. and you add also "position: relative" (this is so you can center the dice) With that then you can add to the dice img: "position: absolute; top: 50%; left: 50%; transform: translate(-50%, -50%); "

  Hopefully this is helpful : ) Keep the GREAT work!

  Marked as helpful

  0

  ---

  

  HualDev•850

  @HualDevPosted over 2 years ago

  @Lfrancos thanks a lot

  0