Advice Generator - Vanilla JS

Community feedback

• 

  Aman Singh Bhogal•1,010

  @asbhogalPosted over 1 year ago

  Hi Levy,

  This is good work. I like the idea of copying the quote too - nice addition. I've ran this through Lighthouse and noticed a few important things however:

  Accessibility

  • Your button is missing an accessible name for screen readers and assistive technologies to determine the function, purpose, destination etc. of the element
  • Your dice image is missing an alt attribute for the same assistive technologies to know what the content and purpose of the image is

  Performance

  • Your image is also missing explicit height and width properties, which can avoid layout shifting issues

  SEO (Although this is a simple app, it's good practice to get into meeting basic SEO standards for when you start to scale up to fully-functioning multiple-page applications. )

  • Your app is missing a meta description to help search crawlers identify and list information about the page
  • As with accessibility, the alt attribute is important for SEO purposes too, as it helps crawlers better understand the content and purpose of the image

  Hope this helps!

  Marked as helpful

  1