Skip to content
Submitted over 1 year ago

Advice Generator using API

victor247k•200
@victor247k
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

I am not sure how to properly set the exact width and height of the element. Also I would appreciate some tips or resources using APIs.

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    ➨ Responsive 💯

    ➨It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.

    ➨ For image like .svg are decorative which browser will not render it to be important and skip it, so it make no sense to add alt leave it blank.

    <picture>
<source media="(max-width:800px)" srcset="images/pattern-divider-mobile.svg">
<img src="images/pattern-divider-desktop.svg" alt="">
</picture>

    ➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord