@jgengo-alt
Posted
Hello there 👋 I'm back to give some advice on your latest assignment :)
I find interesting that you made yourself the -- " --
under the advices instead of using an image, you gain speed in loading the page, that's awesome!
However, what you gain to load the page, you sadly lost it by reloading the page everytime we click the button. Would have been better to make onclick
call a function that would have fetch a new advice and replace only the needed text on the page instead of reloading everything.
Also with a wide screen, your main div would have benefits having a max-width
;)
Keep going 💪
Marked as helpful
@grmbyrn
Posted
@jgengo-alt the -- " -- was mainly an opportunity to practice pseudo-elements as I don't use them very often. Really good advice on the onclick. It's a good idea to get in the habit of making the page more efficient, rather than just sticking with the first thing that works, so thanks!